Replace "Update" with "Edit" in advanced share settings#41680
Merged
AndyScherzinger merged 2 commits intomasterfrom Nov 23, 2023
Merged
Replace "Update" with "Edit" in advanced share settings#41680AndyScherzinger merged 2 commits intomasterfrom
AndyScherzinger merged 2 commits intomasterfrom
Conversation
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Jerome-Herbinet
requested review from
ShGKme,
blizzz,
jancborchardt,
juliusknorr and
szaimen
Jerome-Herbinet
added
design
jancborchardt
approved these changes
Nov 23, 2023
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good! FYI @fenn-cs
Member
Author
Thanks @szaimen ; I would suggest to backport it to Hub 6 ? What do you think ? |
Contributor
|
/compile amend / |
Jerome-Herbinet
changed the title
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
Jerome-Herbinet-change-update-wording
branch
from
66234da to
50d6213
Compare
nfebe
approved these changes
Nov 23, 2023
AndyScherzinger
approved these changes
Nov 23, 2023
Member
|
/backport to stable28 |
Member
Author
|
@AndyScherzinger thanks ! Could it be backported to Nextcloud 27 as well ? (if the share panel has the same structure) |
Member
|
/backport to stable27 |
Member
let's try, yet not to be merged before tomorrow (24th Nov.), we are currently building the maintenance releases for November |
Member
|
/backport to stable27 |
Member
|
@Jerome-Herbinet backporting fails, can you do a manual PR? Thanks 🙏 |
4 tasks
Member
Author
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One recent wording that I have seen in Nextcloud 28 may create confusion in the share dialog : In the advanced rights' settings, we had before "Allow editing". In Nextcloud Hub 7, we'll have "Update". I think it's not relevant and that it will create confusion. I the mind of a lot of people, in a UI, the "update" wording is a pure IT one (e.g. software update). I suggest to use "Edit" instead, to fit the previous notion. In any case, I think that "Edit" is still relevant because, when the checkbox is unchecked, the file is read-only, and it's not possible to "edit" it.
Checklist