fix(files): Adjust table header to look like on previous versions#41710
Merged
fix(files): Adjust table header to look like on previous versions#41710
Conversation
susnux
added
design
Contributor
Author
|
/backport to stable28 |
Member
|
@JuliaKirschenheuter @susnux is this accessible contrast-wise? |
Contributor
Author
Yes it is maxcontrast on main background and maxcontrast on background-hover. Both combinations are tests by our CI for accessibility. |
AndyScherzinger
approved these changes
Nov 24, 2023
artonge
approved these changes
Nov 27, 2023
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
I assume this is still accessible :)
Contributor
Author
|
@jancborchardt @nimishavijay I think this is mainly a design issue, so I would like to wait for your opinion on this. |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-table-header
branch
from
7860a51 to
7809364
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjust the files table header to look like on previous versions by changing the text color.
This now aligns with the table header example from the vue components were we already had a design review by @jancborchardt .
Screenshots
Checklist