Update email template for lost password email

[MorrisJobke]

• requires New emails for sharebymail #4307 to be merged first (only review the last commit in this PR)
• followup to Add IEMailTemplate to public OCP API #4304 and New layout for welcome email #4244 on our way to fix issue Better designed emails when sharing links and calendar etc #2071

Before and after:

[mention-bot]

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @jancborchardt and @LukasReschke to be potential reviewers.

[MorrisJobke]

requires #4307 to be merged first (only review the last commit in this PR)

64873bd

I'm here as well open for help with the texts - cc @nextcloud/designers @Espina2

[codecov-io]

Codecov Report

Merging #4308 into master will increase coverage by 0.05%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #4308      +/-   ##
============================================
+ Coverage     54.14%   54.19%   +0.05%     
  Complexity    21409    21409              
============================================
  Files          1327     1322       -5     
  Lines         81812    81756      -56     
  Branches       1305     1305              
============================================
+ Hits          44298    44310      +12     
+ Misses        37514    37446      -68

Impacted Files	Coverage Δ	Complexity Δ
apps/sharebymail/lib/ShareByMailProvider.php	61.11% <0%> (+0.63%)	62 <0> (-3)	⬇️
lib/private/Mail/EMailTemplate.php	72.22% <75%> (-0.8%)	24 <3> (+3)
core/Controller/LostController.php	82.67% <90%> (+0.03%)	26 <0> (ø)	⬇️
apps/files_external/lib/Lib/Storage/SMB.php	47.22% <0%> (+0.39%)	112% <0%> (ø)	⬇️
lib/private/Files/Cache/Propagator.php	96.2% <0%> (+1.26%)	16% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd1c50...64873bd. Read the comment docs.

[nickvergessen]

Conflicting files
lib/private/Mail/EMailTemplate.php

[Espina2]

Why not something like this?

[schiessle]

Seems like the plain text version suffers from the same issues we discussed and solved here: #4307

So I would suggest to wait for the other PR to get merged, then rebase and adjust it.

[rullzer]

#4307 is in. Rebase needed

[MorrisJobke]

I rebased this one and fixed the plain text email:

Password reset

Click the following link to reset your password. If you have not requested the password reset, then ignore this email.

http://192.168.99.100/server/lostpassword/reset/form/KC0Va7NeBbrnXVK11UVLm/admin

--
Nextcloud - ein sicherer Ort für all Ihre Daten
Dies ist eine automatisch generierte E-Mail, bitte nicht antworten.

Fixed

[rullzer]

Whee!

[enoch85]

Would it be possible to implement @Espina2 fix and use the Sessions + add more text?

[eppfel]

Yeah, @Espina2 copy would be much appreciated.

Too minor edits:

This reset password reset is only available...

Or:

This password reset link is only....

And

For security, this request...

[MorrisJobke]

Would it be possible to implement @Espina2 fix and use the Sessions + add more text?

Not in this PR. Additional PR for sure, but please keep it small.

[MorrisJobke]

@LukasReschke @rullzer Could one of you update the texts like @eppfel proposed? Thanks :)