Don't put the SMTP password into the HTML code#4372
Merged
MorrisJobke merged 4 commits intomasterfrom Apr 18, 2017
Merged
Conversation
Signed-off-by: Joas Schilling <[email protected]>
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @MorrisJobke and @schiessle to be potential reviewers. |
Signed-off-by: Joas Schilling <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4372 +/- ##
=============================================
- Coverage 54.07% 37.63% -16.45%
- Complexity 21589 21591 +2
=============================================
Files 1327 1327
Lines 82303 82280 -23
Branches 1305 1305
=============================================
- Hits 44509 30966 -13543
- Misses 37794 51314 +13520
|
Signed-off-by: Joas Schilling <[email protected]>
Merged
Signed-off-by: Morris Jobke <[email protected]>
blizzz
approved these changes
Apr 18, 2017
MorrisJobke
reviewed
Sep 27, 2018
| <select name='mail_smtpauthtype' id='mail_smtpauthtype'> | ||
| <p id="setting_smtpauth" <?php if ($_['mail_smtpmode'] !== 'smtp') print_unescaped(' class="hidden"'); ?>> | ||
| <label for="mail_smtpauthtype"><?php p($l->t('Authentication method')); ?></label> | ||
| <select name="mail_smtpauthtype" id="mail_smtpauthtype'> |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4354