Skip to content

refactor: Commands and background jobs for the trashbin #54876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 1 commit into from
Jan 29, 2026
Merged

refactor: Commands and background jobs for the trashbin #54876

AndyScherzinger merged 1 commit into from
Jan 29, 2026
+233 −229

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Sep 4, 2025

Summary

  • Use modern node and SetupManager API
  • Avoid passing the user by id and instead use IUser

Originally tried to optimize a bit the number of query but the new code is doing exactly as many DB request as before :( Still a nice cleanup

Checklist

@CarlSchwan CarlSchwan added this to the Nextcloud 33 milestone Sep 4, 2025
@CarlSchwan CarlSchwan self-assigned this Sep 4, 2025
@CarlSchwan CarlSchwan added 2. developing Work in progress ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Sep 4, 2025
@CarlSchwan CarlSchwan force-pushed the carl/cleanup-commands-trash branch from bf64f65 to 63de669 Compare September 11, 2025 15:02
@CarlSchwan CarlSchwan requested a review from artonge September 11, 2025 15:03
@CarlSchwan CarlSchwan marked this pull request as ready for review September 11, 2025 15:04
@CarlSchwan CarlSchwan requested a review from a team as a code owner September 11, 2025 15:04
@CarlSchwan CarlSchwan requested review from Altahrim and sorbaugh and removed request for a team September 11, 2025 15:04
come-nc
come-nc reviewed Sep 15, 2025
View reviewed changes
artonge
artonge reviewed Oct 16, 2025
View reviewed changes
This was referenced Jan 7, 2026
Merged
Merged
This was referenced Jan 14, 2026
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 22, 2026
Merged
@CarlSchwan CarlSchwan force-pushed the carl/cleanup-commands-trash branch 3 times, most recently from 0bee25d to 8d514ba Compare January 28, 2026 20:37
@CarlSchwan
refactor: Commands and background jobs for the trashbin
a8d69ff 
- Use modern node and SetupManager API
- Avoid passing the user by id and instead use IUser

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the carl/cleanup-commands-trash branch from 8d514ba to a8d69ff Compare January 28, 2026 20:44
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 29, 2026
Open
@AndyScherzinger AndyScherzinger merged commit b1a114d into master Jan 29, 2026
225 of 236 checks passed
@AndyScherzinger AndyScherzinger deleted the carl/cleanup-commands-trash branch January 29, 2026 12:44
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 29, 2026

/backport to stable33

@backportbot backportbot bot mentioned this pull request Jan 29, 2026
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge left review comments

@come-nc come-nc come-nc left review comments

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@Altahrim Altahrim Altahrim approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@CarlSchwan CarlSchwan

Labels

2. developing Work in progress ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

6 participants

@CarlSchwan @AndyScherzinger @Altahrim @artonge @come-nc