-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(settings): update all button only updates a single app #56923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@AndyScherzinger DCO is red. Can we still merge this? |
820b846 to
6e719ec
Compare
Member
Author
|
@szaimen I fixed the DCO 👍 |
szaimen
approved these changes
Dec 8, 2025
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
Merged
Member
Author
|
/compile rebase |
Signed-off-by: Thomas Lamant <[email protected]>
Signed-off-by: Thomas Lamant <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
7b8b7a2 to
f6a783e
Compare
Altahrim
approved these changes
Jan 8, 2026
Contributor
|
/backport to stable32 |
2 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the chain of functions involved in the "update all apps" routine were not properly setup up with regards to asynchronism:
updateAll()were not awaited or managed properlyupdatefunction fed top-limit'slimit()utility was returning void and not a promise, as it expects (see docs)This was causing the mechanism driving the updates to potentially end prematurely.
This PR fixes this by:
async/awaitandPromises.allinupdateAll()to ensure all promises generated by p-limit are awaited and executed completely before the function finishes.update()return the promises it involvesThis would prevent the function from exiting prematurely and ensure all updates are processed automatically.
Checklist
3. to review, feature component)stable32)