-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(mimetypes): Add mimetype aliases/mapping/names for .toml and .ovpn #57480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good overall, yet I am wondering if it is also missing a repair step, like |
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think so.
|
Repair thing needs be done by some one else then, not much idea about PHP and i don't want to touch anything called "repair" as too risky for me. |
|
You can basically copy the exact changes from the link, but adjusted with your mimetypes. |
c238038 to
2871bc9
Compare
|
@provokateurin I took the liberty to rebase and add 2871bc9 - please feel free to re-review (if my change) is sufficient 🙏 |
|
also @provokateurin @Altahrim @CarlSchwan if I look at https://github.com/nextcloud/server/pull/54447/changes#diff-d08941a4637c8c4f1f8696a141bc55d59d10352e2338015e9f675fc86fdbf2bf there are also further files that get touched, not sure this would also apply here (not an expert on the mime-type implementation) |
|
Repair topic would need be done by some one else then, i'm not submitting code i'm not able to test (which is the case here). 🙁 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: iasdeoupxe <39667843+iasdeoupxe@users.noreply.github.com> Signed-off-by: provokateurin <kate@provokateurin.de>
2871bc9 to
afde920
Compare
|
I updated the JS and signature files, so it should be good to merge now. |
|
Cypress won't run because it's from a fork, but I don't think we need it for these changes. @AndyScherzinger can you force merge? |
|
/backport to stable33 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/57480/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick afde9209
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57480/stable33Error: Failed to push branch backport/57480/stable33: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable33 |
Summary
.ovpn:.toml:Note: Also moved one
textentry up to have sorted it correctly like others.TODO
N/A
Checklist
3. to review, feature component)stable32)