Skip to content

Conversation

@iasdeoupxe
Copy link
Contributor

Summary

Note: Also moved one text entry up to have sorted it correctly like others.

TODO

N/A

Checklist

@iasdeoupxe iasdeoupxe requested a review from a team as a code owner January 10, 2026 13:48
@iasdeoupxe iasdeoupxe requested review from Altahrim, nfebe, provokateurin and sorbaugh and removed request for a team January 10, 2026 13:48
@AndyScherzinger
Copy link
Member

Looks good overall, yet I am wondering if it is also missing a repair step, like
https://github.com/nextcloud/server/pull/51703/changes which would then need to be for 33.0.0 - right @CarlSchwan @Altahrim ?

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think so.

@iasdeoupxe iasdeoupxe changed the title feat: Add mimetype aliases/mapping/names for .toml and .ovpn feat(mimetypes): Add mimetype aliases/mapping/names for .toml and .ovpn Jan 19, 2026
@iasdeoupxe
Copy link
Contributor Author

Repair thing needs be done by some one else then, not much idea about PHP and i don't want to touch anything called "repair" as too risky for me.

@provokateurin
Copy link
Member

You can basically copy the exact changes from the link, but adjusted with your mimetypes.

@AndyScherzinger
Copy link
Member

@provokateurin I took the liberty to rebase and add 2871bc9 - please feel free to re-review (if my change) is sufficient 🙏

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 19, 2026

also @provokateurin @Altahrim @CarlSchwan if I look at https://github.com/nextcloud/server/pull/54447/changes#diff-d08941a4637c8c4f1f8696a141bc55d59d10352e2338015e9f675fc86fdbf2bf there are also further files that get touched, not sure this would also apply here (not an expert on the mime-type implementation)
Plus also 397910c suggesting signatures need to be re-calculated (!)

@iasdeoupxe
Copy link
Contributor Author

iasdeoupxe commented Jan 19, 2026

Repair topic would need be done by some one else then, i'm not submitting code i'm not able to test (which is the case here). 🙁

This was referenced Jan 20, 2026
@AndyScherzinger AndyScherzinger removed this from the Nextcloud 33 milestone Jan 24, 2026
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Signed-off-by: iasdeoupxe <39667843+iasdeoupxe@users.noreply.github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin requested a review from a team as a code owner January 26, 2026 06:24
@provokateurin provokateurin removed the request for review from a team January 26, 2026 06:24
@provokateurin provokateurin requested a review from susnux January 26, 2026 06:24
@provokateurin
Copy link
Member

I updated the JS and signature files, so it should be good to merge now.

@provokateurin
Copy link
Member

Cypress won't run because it's from a fork, but I don't think we need it for these changes. @AndyScherzinger can you force merge?

@AndyScherzinger AndyScherzinger merged commit 588f7cd into nextcloud:master Jan 26, 2026
161 of 168 checks passed
@AndyScherzinger
Copy link
Member

/backport to stable33

@backportbot
Copy link

backportbot bot commented Jan 26, 2026

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/57480/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick afde9209

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57480/stable33

Error: Failed to push branch backport/57480/stable33: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@AndyScherzinger
Copy link
Member

/backport to stable33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants