Skip to content

Comments

fix(files): fix tab navigation from select all checkbox to batch actions#58457

Merged
skjnldsv merged 2 commits intomasterfrom
fix/a11y-select-header-all
Feb 20, 2026
Merged

fix(files): fix tab navigation from select all checkbox to batch actions#58457
skjnldsv merged 2 commits intomasterfrom
fix/a11y-select-header-all

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 20, 2026

Fix #58386

Not too convinced, but code is clean and it works™

Checklist

@skjnldsv skjnldsv requested a review from a team as a code owner February 20, 2026 09:46
@skjnldsv skjnldsv requested review from artonge, sorbaugh and szaimen and removed request for a team February 20, 2026 09:46
@skjnldsv skjnldsv self-assigned this Feb 20, 2026
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: files papercut Annoying recurring UX issue with possibly simple fix. accessibility labels Feb 20, 2026
@skjnldsv skjnldsv added this to the Nextcloud 34 milestone Feb 20, 2026
@skjnldsv
Copy link
Member Author

/backport to stable33

@skjnldsv
Copy link
Member Author

/backport to stable32

@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team Feb 20, 2026
@skjnldsv skjnldsv moved this from Todo to In Progress in A11Y initiative 2026 Feb 20, 2026
@skjnldsv skjnldsv requested a review from susnux February 20, 2026 09:59
@skjnldsv skjnldsv force-pushed the fix/a11y-select-header-all branch from 9ce547c to 0a5ee8d Compare February 20, 2026 10:05
@skjnldsv
Copy link
Member Author

/compile

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good solution, just some comments for readability

@skjnldsv skjnldsv force-pushed the fix/a11y-select-header-all branch from 38e31f4 to ceed261 Compare February 20, 2026 13:30
@skjnldsv
Copy link
Member Author

/compile rebase

@skjnldsv skjnldsv requested a review from susnux February 20, 2026 13:31
skjnldsv and others added 2 commits February 20, 2026 13:36
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/a11y-select-header-all branch from ceed261 to e614d8f Compare February 20, 2026 13:39
@skjnldsv skjnldsv enabled auto-merge February 20, 2026 13:58
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now its screaming at me but thats fine 😆

@skjnldsv skjnldsv merged commit 6873b96 into master Feb 20, 2026
126 checks passed
@skjnldsv skjnldsv deleted the fix/a11y-select-header-all branch February 20, 2026 13:59
@github-project-automation github-project-automation bot moved this from In Progress to Done in A11Y initiative 2026 Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews accessibility bug feature: files papercut Annoying recurring UX issue with possibly simple fix.

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

[files] wrong tab order of file-list actions

4 participants