Downstream 26539 & 28074 - proper handling of invalid config #6149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
LukasReschke,
icewind1991,
nickvergessen and
rullzer
MorrisJobke
changed the title
icewind1991
requested changes
Aug 16, 2017
|
|
||
| use OCP\Files\StorageNotAvailableException; | ||
|
|
||
| class InvalidStorage { |
Member
There was a problem hiding this comment.
There is an OC\Files\Storage\FailedStorage that should probably bne reused instead
Member
Author
There was a problem hiding this comment.
I rebased this. Sadly I wasn't apply to make this change here happen. @icewind1991 Could you please help me here? Thanks
MorrisJobke
force-pushed
the
downstream-26539
branch
from
3644357 to
d973512
Compare
Codecov Report
@@ Coverage Diff @@
## master #6149 +/- ##
=========================================
Coverage ? 54.41%
Complexity ? 21175
=========================================
Files ? 1311
Lines ? 82417
Branches ? 1329
=========================================
Hits ? 44850
Misses ? 37567
Partials ? 0
|
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
downstream-26539
branch
from
d973512 to
2cb3461
Compare
Member
Author
|
I removed the commits regarding the handling of storages and made a separate PR out of it. This is now ready for review. |
Member
Author
|
Please re-review. |
LukasReschke
approved these changes
Aug 21, 2017
rullzer
approved these changes
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a downstream of owncloud/core#28074
and owncloud/core#26539 to make it easy to test. owncloud/core#26539 is also needed for #6146 (to review: look into both commits separately)