Adjust background image to the one used on the website#6303
Merged
MorrisJobke merged 2 commits intomasterfrom Aug 29, 2017
Merged
Adjust background image to the one used on the website#6303MorrisJobke merged 2 commits intomasterfrom
MorrisJobke merged 2 commits intomasterfrom
Conversation
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
jancborchardt
added
3. to review
jancborchardt
requested review from
Espina2,
LukasReschke,
MorrisJobke,
eppfel,
juliusknorr,
pixelipo and
skjnldsv
MorrisJobke
added
4. to release
Contributor
|
Looks good to me. 🚀 |
Espina2
approved these changes
Aug 29, 2017
Contributor
|
Hey @jancborchardt, |
Member
|
@dartcafe Could you open a new ticket for this? Thanks |
Member
|
Perfect!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step towards more consistency between website and app. :) Also adjusted the button style to use the actual theming color instead of a lighter shade, which looked a bit off always.
Please review @nextcloud/designers @MorrisJobke @LukasReschke, this uses the background image made by @Espina2 for https://nextcloud.com
Before:
After:
Works well with theming cc @nextcloud/theming
