Merged
Conversation
Followup to #7264 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
8fb2f33 to
54c227b
Compare
Member
Author
|
I also added an unit tests that check this behaviour ;) |
rullzer
approved these changes
Dec 14, 2017
Codecov Report
@@ Coverage Diff @@
## master #7506 +/- ##
============================================
+ Coverage 51.11% 51.16% +0.05%
+ Complexity 24903 24865 -38
============================================
Files 1601 1601
Lines 94778 94683 -95
Branches 1368 1368
============================================
+ Hits 48445 48446 +1
+ Misses 46333 46237 -96
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #7264
Before it just fetched the list again and again 🙈