Conversation
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
When clicking on "Share link" in the "Sharing" tab of the Files app an input field with the link appears. That input field already exists in the DOM, although empty, before clicking on "Share link", and when that is done the proper value is set and then the input field is shown. In the acceptance tests "getValue()" can return the value of hidden elements too, so as long as an element exists its value is returned without waiting for the field to be visible. Due to this if the test code runs too fast the "I write down the shared link" step could be executed before the proper value was set, so the shared link got in that case would be an empty value, and this would lead to failures when the following steps were executed. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #7605 +/- ##
============================================
+ Coverage 51.16% 51.17% +<.01%
Complexity 24886 24886
============================================
Files 1602 1602
Lines 94750 94750
Branches 1368 1368
============================================
+ Hits 48480 48486 +6
+ Misses 46270 46264 -6
|
MorrisJobke
approved these changes
Dec 22, 2017
rullzer
deleted the
wait-for-the-shared-link-to-be-set-in-the-acceptance-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clicking on Share link in the Sharing tab of the Files app an input field with the link appears. That input field already exists in the DOM, although empty, before clicking on Share link, and when that is done the proper value is set and then the input field is shown.
In the acceptance tests
getValue()can return the value of hidden elements too, so as long as an element exists its value is returned without waiting for the field to be visible. Due to this if the test code runs too fast the I write down the shared link step could be executed before the proper value was set, so the shared link got in that case would be an empty value. Then, when the link was tried to be visited no web page would load, and the acceptance test failed with a message like:This pull request should prevent those failures from appearing again. Once it is "confirmed" that it works (that is, the failures have not been seen in a while, as unfortunately they are not deterministic :-( ) it should be backported to stable12 too.