Merged
Conversation
* Always show delete icon * Hide form if the new icon is deleted
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst, @jancborchardt and @icewind1991 to be potential reviewers |
Member
|
@jancborchardt how about we make the input field a bit wider and put the clipboard-js icon into it, like with the login button on the login screen? |
Member
|
@ChristophWurst sounds like a good idea. But we should unify this, so that it looks everywhere the same. |
Member
Author
|
I'm all for it but lets do that separatly against master so we can get this in and backported. |
Member
|
I tested this and it works fine. I only added a bit more margin between copy icon and "Done" button to have it look nicer. |
Member
|
👍 |
Member
Member
|
LGTM |
Merged
Member
|
Nice, good stuff @rullzer @MorrisJobke 🚀 |
GitHubUser4234
pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

For #735
Before:

After:

CC: @MorrisJobke @schiessle @jancborchardt @ChristophWurst @LukasReschke