Conversation
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #8078 +/- ##
===========================================
- Coverage 51.7% 6.6% -45.1%
- Complexity 25426 25428 +2
===========================================
Files 1598 1598
Lines 95241 95251 +10
Branches 1376 1376
===========================================
- Hits 49243 6293 -42950
- Misses 45998 88958 +42960
|
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
d4c3384 to
6770213
Compare
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
rullzer
reviewed
Jan 27, 2018
| return false; | ||
| } | ||
| } | ||
| return true; |
Member
There was a problem hiding this comment.
yes please... the old code was clearly me messing up 😉
Member
|
Awesome!!! Thanks @juliushaertl ! |
MorrisJobke
approved these changes
Jan 29, 2018
Member
Author
|
backport at #8156 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.