Conversation
|
@juliushaertl, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @schiessle and @nickvergessen to be potential reviewers |
apps/theming/appinfo/routes.php
Outdated
| ], | ||
| [ | ||
| 'name' => 'Theming#getJavascript', | ||
| 'url' => '/js/theming.js', |
There was a problem hiding this comment.
This did cause problems with some Nginx configs in the past. I'd advociate to keep the .js out at the end. Just to be on the safe side. As long as the mimetype is correct this shouldn't harm.
There was a problem hiding this comment.
Just pushed the update. Thanks for the hint.
juliusknorr
force-pushed
the
theming-support-for-apps
branch
from
87df041 to
5f4e88e
Compare
|
Code looks good and works 👍 |
|
👍 |
LukasReschke
added
4. to release
I opened an issue in the documentation repo. |
|
@juliushaertl Could I ask you to open the backport PR for stable10? Thanks :) |
|
@MorrisJobke done. backport at #833 |
Theming support for apps
5 participants
This pr provides the following enhancements for app developers, who want to add support for theming:
CSS classes:
.nc-theming-main-background Background in theming color
.nc-theming-main-text Text in theming color
.nc-theming-contrast Text in white/black to be shown in front of the theming color
JavaScript Object OCA.Theming
with nextcloud/notifications#9 this fixes notification icon in top left is white instead of black in #735