Also array_slice wide email matches of local users#8596
Merged
MorrisJobke merged 2 commits intomasterfrom Mar 6, 2018
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
juliusknorr
approved these changes
Mar 1, 2018
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Works as expected now 👍 Thanks @nickvergessen
nickvergessen
commented
Mar 1, 2018
|
|
||
| if (!$this->shareeEnumeration) { | ||
| $result['wide'] = []; | ||
| $userResults['wide'] = []; |
Member
Author
There was a problem hiding this comment.
PS: also enumeration was possible before, pretty bad...
Member
|
Ah failing tests |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Codecov Report
@@ Coverage Diff @@
## master #8596 +/- ##
=============================================
- Coverage 51.93% 35.02% -16.91%
Complexity 25418 25418
=============================================
Files 1609 1609
Lines 95329 95331 +2
Branches 1378 1378
=============================================
- Hits 49506 33389 -16117
- Misses 45823 61942 +16119
|
Member
Author
|
Fixed |
Member
|
test case for it possible? |
Member
Still pending and should be done together with the Backport. |
Member
Author
|
Tests in #8710 |
Member
Author
|
Backport in #8749 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8454