Skip to content

[stable13] Fix comments (and systemtags) when involving users with numerical ids#8615

Merged
MorrisJobke merged 1 commit intostable13from
stable13-8355
Mar 2, 2018
Merged

[stable13] Fix comments (and systemtags) when involving users with numerical ids#8615
MorrisJobke merged 1 commit intostable13from
stable13-8355

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Mar 1, 2018

backport of #8355 to stable13

test creating comments with numeric user ids

Signed-off-by: Arthur Schiwon <[email protected]>

fix creating comments when file is accessible to users with numeric ids

Signed-off-by: Arthur Schiwon <[email protected]>

tests for systemtags related to numeric user ids

Signed-off-by: Arthur Schiwon <[email protected]>

fix systemtags event with numeric user ids

Signed-off-by: Arthur Schiwon <[email protected]>
@codecov
Copy link

codecov bot commented Mar 2, 2018

Codecov Report

Merging #8615 into stable13 will increase coverage by 0.07%.
The diff coverage is 94%.

@@              Coverage Diff               @@
##             stable13    #8615      +/-   ##
==============================================
+ Coverage       51.22%   51.29%   +0.07%     
- Complexity      24992    24994       +2     
==============================================
  Files            1608     1609       +1     
  Lines           95126    95223      +97     
  Branches         1376     1376              
==============================================
+ Hits            48726    48848     +122     
+ Misses          46400    46375      -25
Impacted Files Coverage Δ Complexity Δ
apps/systemtags/lib/Activity/Listener.php 0% <0%> (ø) 33 <0> (ø) ⬇️
apps/comments/lib/Activity/Listener.php 80.39% <100%> (+56.86%) 10 <0> (ø) ⬇️
apps/comments/tests/Unit/Activity/ListenerTest.php 95.83% <95.83%> (ø) 2 <2> (?)
core/js/js.js 66.4% <0%> (+0.11%) 0% <0%> (ø) ⬇️

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke merged commit 59d6f45 into stable13 Mar 2, 2018
@MorrisJobke MorrisJobke deleted the stable13-8355 branch March 2, 2018 09:35
@MorrisJobke MorrisJobke mentioned this pull request Mar 9, 2018
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants