Various css fixes

[skjnldsv]

• Fixed inline icon-confirm state to be on top of the input (z-index: 2)
• Fixed the visibility of the icon in app-navigation and the collapsible indicator (triangle) if there is a bullet used

@nextcloud/designers easy one ;)

[skjnldsv]

If we have a icon-loading, the after is already used. Let's use the before for the collapsible triangle indicator

[skjnldsv]

Failure unrelated

[juliusknorr]

@skjnldsv Any places where this causes problems, so we can test that easily?

[skjnldsv]

@juliushaertl for the confirm icon, not really! I encountered it in a test, so this is a css prop just in case. (z index can be reviewed as code, it's a simple edit)

For the icon loading navigation, easy one, remove all the entries in the app-navigation (on any nextcloud page you want), and add this instead:

<li class="collapsible open">
    <a href="#" class="icon-folder">Folder collapsed menu</a>
    <ul>
        <li><a href="#">Simple entry</a></li>
        <li><a href="#">Simple entry</a></li>
        <li><a href="#">Simple entry</a></li>
        <li>
            <a class="icon-folder" href="#">Simple folder</a>
        </li>
    </ul>
</li>

Toggle the icon-loading-small class on the li and hover the whole entry to see the loading triangle rotate instead of the loader.

[codecov]

Codecov Report

Merging #8777 into master will decrease coverage by 0.49%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master    #8777     +/-   ##
===========================================
- Coverage     51.82%   51.32%   -0.5%     
- Complexity    25281    25380     +99     
===========================================
  Files          1604     1542     -62     
  Lines         94804    87342   -7462     
  Branches       1377        0   -1377     
===========================================
- Hits          49131    44828   -4303     
+ Misses        45673    42514   -3159

Impacted Files	Coverage Δ	Complexity Δ
...aring/lib/Controller/MountPublicLinkController.php	21.52% <0%> (-20.37%)	24% <0%> (+10%)
lib/public/Util.php	44.28% <0%> (-15.91%)	59% <0%> (+14%)
lib/public/Share.php	35.29% <0%> (-4.71%)	7% <0%> (+1%)
settings/Controller/GroupsController.php	64.61% <0%> (-3.72%)	9% <0%> (ø)
lib/private/Security/CertificateManager.php	91% <0%> (-3%)	39% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Provider/Base.php	76.78% <0%> (-2.58%)	16% <0%> (-3%)
lib/private/legacy/api.php	34.01% <0%> (-1.41%)	72% <0%> (+41%)
apps/updatenotification/lib/UpdateChecker.php	71.42% <0%> (-1.3%)	8% <0%> (ø)
...private/Collaboration/Collaborators/MailPlugin.php	75.72% <0%> (-0.91%)	29% <0%> (-2%)
lib/private/legacy/json.php	9.83% <0%> (-0.88%)	25% <0%> (+2%)
... and 131 more

[skjnldsv]

Failure unrelated:

Once merged, backport of the icon-confirm will be needed for backward compatibility of some apps that uses it.

[skjnldsv]

Bump? @nextcloud/designers

[rullzer]

🐘

[MorrisJobke]

@skjnldsv RC time means time for backports 😉