Merged
Conversation
rullzer
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
nickvergessen
nickvergessen
approved these changes
Mar 26, 2018
ChristophWurst
added
4. to release
rullzer
added
2. developing
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Codecov Report
@@ Coverage Diff @@
## master #8985 +/- ##
============================================
- Coverage 53.58% 30% -23.58%
Complexity 23981 23981
============================================
Files 1443 1442 -1
Lines 80307 78854 -1453
============================================
- Hits 43030 23661 -19369
- Misses 37277 55193 +17916
|
MorrisJobke
reviewed
Mar 26, 2018
| * @deprecated 8.1.0 use prepare() of \OCP\IDBConnection - \OC::$server->getDatabaseConnection() | ||
| * @since 4.5.0 | ||
| */ | ||
| static public function prepare( $query, $limit=null, $offset=null ) { |
Member
There was a problem hiding this comment.
Will fix the activity tests...
=> nextcloud/activity#259
This was referenced Mar 26, 2018
rullzer
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.