[stable13] Use app version to generate scss filename#9015
Merged
MorrisJobke merged 1 commit intostable13from Apr 3, 2018
Merged
[stable13] Use app version to generate scss filename#9015MorrisJobke merged 1 commit intostable13from
MorrisJobke merged 1 commit intostable13from
Conversation
Fixed scsscacher tests Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
LukasReschke,
MorrisJobke,
juliusknorr,
kyrofa and
rullzer
skjnldsv
changed the title
Member
|
This one I'm able to test! Unfortunately, when snapped and using a datadirectory in /media, the CSS cache still doesn't look right after upgrade from 12 to this PR:
|
Codecov Report
@@ Coverage Diff @@
## stable13 #9015 +/- ##
==============================================
+ Coverage 51.33% 51.34% +<.01%
- Complexity 25027 25029 +2
==============================================
Files 1609 1609
Lines 95298 95305 +7
Branches 1376 1376
==============================================
+ Hits 48922 48931 +9
+ Misses 46376 46374 -2
|
kyrofa
approved these changes
Mar 28, 2018
Member
kyrofa
left a comment
kyrofa
left a comment
There was a problem hiding this comment.
This does not fix the issue I was hoping it would, but it doesn't regress behavior and is a positive change. +1 from me, thank you!
MorrisJobke
approved these changes
Apr 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #8999