Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
|
Can we extract this to a fuction and add tests for it? |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
Author
|
Done |
Codecov Report
@@ Coverage Diff @@
## master #9225 +/- ##
============================================
+ Coverage 51.91% 51.91% +<.01%
- Complexity 25361 25366 +5
============================================
Files 1606 1607 +1
Lines 95311 95328 +17
Branches 1394 1394
============================================
+ Hits 49478 49489 +11
- Misses 45833 45839 +6
|
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Member
|
I just added some more tests to cover also domain names 😉 |
MorrisJobke
approved these changes
Apr 19, 2018
Member
MorrisJobke
left a comment
There was a problem hiding this comment.
Code makes sense and still works 👍
rullzer
approved these changes
Apr 22, 2018
Member
|
@nickvergessen Could you open the backport for stable13? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace #7621
Fix #9157