Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 11, 2020

#250

Null is returned by a pregmatch not an empty string.

@ghost ghost changed the title Fix FreeBSD Exception (null not string returned from speed/duplex) Fix FreeBSD Exception Oct 11, 2020
@ghost ghost marked this pull request as ready for review October 11, 2020 01:47
@ghost ghost changed the title Fix FreeBSD Exception Fix FreeBSD Interface Exception Oct 11, 2020
@ghost ghost mentioned this pull request Oct 11, 2020
@kesselb
Copy link
Collaborator

kesselb commented Oct 11, 2020

Are you able to reproduce this on your box? I would like to add unit tests at some point for the network logic (like we already have for memory and disks) so every breaking input is nice to have ;)

I'm tried one of the reports from the issue but the input seems to work: https://3v4l.org/lPiVo

@ghost
Copy link
Author

ghost commented Oct 11, 2020

Are you able to reproduce this on your box? I would like to add unit tests at some point for the network logic (like we already have for memory and disks) so every breaking input is nice to have ;)
I'm tried one of the reports from the issue but the input seems to work: https://3v4l.org/lPiVo

I was able to reproduce the issue by adding a bridge interface.

Checking for the null does work. I also added a default for a null status. Not sure what kind of default to add for mac/ipv4/ipv6.

image

bridge0: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
        ether 00:00:00:00:00:00
        id 00:00:00:00:00:00 priority 32768 hellotime 2 fwddelay 15
        maxage 20 holdcnt 6 proto rstp maxaddr 2000 timeout 1200
        root id 00:00:00:00:00:00 priority 0 ifcost 0 port 0
        groups: bridge
        nd6 options=9<PERFORMNUD,IFDISABLED>

Signed-off-by: Matthew Wener <[email protected]>
@kesselb kesselb merged commit 3230b6e into nextcloud:master Oct 12, 2020
@kesselb
Copy link
Collaborator

kesselb commented Oct 12, 2020

/backport to stable20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants