Add acceptance tests #768
Merged
Add acceptance tests #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds the base configuration needed to run acceptance tests for the Talk app. The script to run the acceptance tests simply calls the "run.sh" script from the server acceptance tests specifying the directory of the acceptance tests for the Talk app. The installation script called before the acceptance tests are actually run is extended from the one used in the acceptance tests for the server to also enable the Talk app. Due to Behat limitations, the Behat configuration used in the acceptance tests for the server can not be extended; the configuration used is exclusive for the Talk app. Due to that some parameters must be duplicated from the Behat configuration for the server acceptance tests (like the session definitions). In any case, the core library and all the contexts for the server are automatically available in the acceptance tests for apps; their path does not need to be set in the "autoload" section, although the specific contexts to be used have to be explicitly set; the ones included are those needed (either directly or due to dependencies) to be able to use the "I am logged in"/"I am logged in as the admin" steps, which are the most basic steps needed by the acceptance tests for almost every app. On the other hand, the paths to the features and the contexts from the Talk app must be explicitly set in the configuration. Finally, note that this commit does not include any test feature, so calling "run.sh" would just end in a failure; some basic test features will be added in a following commit. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The Talk app requires a multi-threaded web server (due to its use of long polling), so the configuration of the acceptance tests is changed to use the Apache web server instead of the default PHP built-in web server. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
add-acceptance-tests
branch
from
f5e7d36 to
8cbc5c3
Compare
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The acceptance tests requires the grandparent directory of the root directory of the app to be the root directory of the Nextcloud server. Drone only clones the app repository, so the Nextcloud server repository has to be explicitly cloned and the app moved to the "apps" directory before the tests are run. Besides that, as the acceptance tests need to be run on Apache, "/var/www/html" has to be linked to the root directory of the Nextcloud server. Once all that is done the tests can be run in the same way that they are run in Drone for the Nextcloud server but just specifying the acceptance tests directory too. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
add-acceptance-tests
branch
from
8cbc5c3 to
137e7c6
Compare
danxuliu
added
2. developing
3. to review
and removed
3. to review
2. developing
labels
This was referenced Apr 11, 2018
Ivansss
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires nextcloud/server#9114 and nextcloud/server#9127
This pull request adds support for acceptance tests to Nextcloud Talk and provides a basic set of tests for conversations (creating conversations, changing and removing them); more tests will be added in following pull requests.