fix(sync): lastSavedVersion is version send with the request#7694
Merged
Conversation
The client sends a serialized version of the document plus the document state according to the steps it received until that point (maybe plus local edits that were not synced yet). lastSavedVersion should be the version the client had seen at the time it initiated the save request not the last version of any step the server saw when receiving the request. Otherwise when loading the document or attempting to recover from missing steps the steps in between will be left out. Signed-off-by: Max <max@nextcloud.com>
mejo-
approved these changes
Sep 29, 2025
Member
|
/backport to stable32 |
Member
|
/backport to stable31 |
This was referenced Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7692 .
In the save request the client sends:
$version)$stepsVersionis the latest version the server has seen until now.lastSavedVersionshould be$version- i.e. the version the client has processedat the time it initiated the save request.
Otherwise when loading the document
or attempting to recover from missing steps
the steps between
$versionand$stepsVersionwill be left out.Network captures
Left is client that saved, right is client that was sending changes constantly.
Left client saved with
"version":14830451. Document is saved withlastSavedVersionset to 14830508.Impact
While this does explain why the client could not recover from missing a step it does not explain why it did not process the step it received in the first place.