Support PHP 7.3

[xf-]

PHP 7.3 works in my instance

[ChristophWurst]

Thanks!

• CI fails https://travis-ci.org/nextcloud/twofactor_u2f/jobs/455794009#L1739
• Requires a Nextcloud server with php7.3 support

[xf-]

CI fails https://travis-ci.org/nextcloud/twofactor_u2f/jobs/455794009#L1739

Yes, travis didn't start for 30m and i gone to sleep :) Maybe a plugin is missing (travis PHP 7.3 support ticket had some build issues of extensions)

Requires a Nextcloud server with php7.3 support

Nextcloud backported only known issue i had to v14.0.1 (no official support) and according to github issue v15 will release with official PHP v7.3 support

[ChristophWurst]

Nextcloud backported only known issue i had to v14.0.1 (no official support) and according to github issue v15 will release with official PHP v7.3 support

I totally missed that. nextcloud/server#11745 🚀

[ChristophWurst]

Yes, travis didn't start for 30m and i gone to sleep :) Maybe a plugin is missing (travis PHP 7.3 support ticket had some build issues of extensions)

I doubt it's a temporary issue, but I've restarted the build anyway.

[xf-]

I mean xdebug is missing and you can't remove the ini.

Solutions:

• ${TRAVIS_PHP_VERSION:0:3} != "7.3" - xdebug could be added after an new xdebug release.
• Test if file exists but phpenv has minor version in path (no feature like phpenv config-exists xdebug.ini)
• Ignore the error - disable for speed is only possible if extension is loaded. I will try to avoid the error and exit

[xf-]

@ChristophWurst looks like saucelabs failed

[ChristophWurst]

@ChristophWurst looks like saucelabs failed

That's because Travis hides the API keys for PRs from forked repositories.

[xf-]

@ChristophWurst works like u2f

[DrissiReda]

any way I can integrate this to my own nextcloud installation?

[ChristophWurst]

any way I can integrate this to my own nextcloud installation?

You can of course just edit your local copy of the source code. As usual, you're on your own if anything breaks. I recommend waiting for an official release. Testing and feedback is highly appreciated in the meantime.

[xf-]

@DrissiReda you can always load the patch on github with append .patch
https://patch-diff.githubusercontent.com/raw/nextcloud/twofactor_totp/pull/319.patch
and apply it with patch