Fix key registration#323
Conversation
|
Let me know if there are any changes I need to make. |
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
The only thing missing is bumping the version in info.xml. Change
twofactor_webauthn/appinfo/info.xml
Line 7 in 9c60f87
Did you want the line to read <version>1.1.1-alpha.0</version> or <version>1.1.0-alpha.1</version> |
|
The second one :) |
|
It looks like there are some workflows that need to be run before this PR can be merged. Is there anything I need to do on my end? |
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Nitpick
When you amend your commit, change the commit message from Fix key registration to fix(database schema): Fix public key column size
|
/backport to stable1.0 |
backportbot-nextcloud
bot
added
the
backport-request
|
I changed the commit message as you requested. |
|
My apologies, it seems that I forgot to add a blank line before the footer of the commit message. It should be fixed now. |
|
Not sure why the commit message check is failing. Perhaps the scope must be limited to a single word? i.e. |
st3iny
added
bug
Fixes #233 Signed-off-by: Zev Lee <60147316+zevlee@users.noreply.github.com> Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
|
/backport to stable1.1 |
|
/backport to stable1.1 |
3 participants
Fixes #233
Signed-off-by: Zev Lee 60147316+zevlee@users.noreply.github.com