Force apply Mime mixin to all components handler#471
Merged
Conversation
skjnldsv
added
enhancement
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
v1r0x
approved these changes
Apr 16, 2020
v1r0x
left a comment
v1r0x
left a comment
There was a problem hiding this comment.
Looks good and works fine for files_3d 🐧 👍
Member
Author
|
@ariselseng can you also check this please? :) |
Member
Author
|
Same for you Julius (when you'll be back), for the Text app :) |
Member
Author
|
/compile amend / |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
fix/force-apply-mixin
branch
from
b17ff03 to
ea0dab0
Compare
skjnldsv
force-pushed
the
fix/force-apply-mixin
branch
6 times, most recently
from
4413642 to
b0db670
Compare
Member
Author
|
/compile amend / |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
fix/force-apply-mixin
branch
from
b0db670 to
4117f90
Compare
Member
Author
|
As this is a really big change, I will not backport it, so it will be for 19 and above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com