Skip to content

Fix recording stop on disconnect #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hweihwang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix recording stop on disconnect #993

hweihwang wants to merge 2 commits into from

Conversation

@hweihwang
Copy link
Contributor

@hweihwang hweihwang commented Jan 28, 2026 •
edited
Loading

Summary

  • stop recordings when the recorder has no active non‑recording connections after a 5s grace window (tab/window closed or connection dropped)
  • add a personal opt‑in to auto‑save recordings on disconnect (default: off; supports saving even if the tab is already closed)
image

@hweihwang hweihwang requested review from benjaminfrueh and silverkszlo and removed request for grnd-alt January 28, 2026 11:38
@hweihwang hweihwang linked an issue Jan 28, 2026 that may be closed by this pull request
Recording not stopped when recorder disconnects (headless Chromium leak) #985
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr Awaiting requested review from juliusknorr juliusknorr is a code owner

@silverkszlo silverkszlo Awaiting requested review from silverkszlo

@benjaminfrueh benjaminfrueh Awaiting requested review from benjaminfrueh

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recording not stopped when recorder disconnects (headless Chromium leak)

2 participants

@hweihwang