Skip to content

Fix recording initial viewport follow#996

Merged
benjaminfrueh merged 1 commit intomainfrom
fix/recording-initial-viewport
Feb 3, 2026
Merged

Fix recording initial viewport follow#996
benjaminfrueh merged 1 commit intomainfrom
fix/recording-initial-viewport

Conversation

@hweihwang
Copy link
Contributor

@hweihwang hweihwang commented Jan 28, 2026 •
edited
Loading

Summary

  • request viewport immediately when recording agent follows a user so initial recording shows current view
  • should be tested against this changes first Fix recording runtime cache busting #994 (cherry pick the cache busting for recording agent first)

@hweihwang
fix: request viewport on recording follow
69edd6e 
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang hweihwang requested review from benjaminfrueh and silverkszlo and removed request for grnd-alt January 28, 2026 13:26
@hweihwang hweihwang linked an issue Jan 28, 2026 that may be closed by this pull request
Recording starts at origin / looks empty until first scroll (recording followUser doesn’t request viewport) #987
Closed
@benjaminfrueh benjaminfrueh merged commit 56888d9 into main Feb 3, 2026
32 checks passed
@benjaminfrueh benjaminfrueh deleted the fix/recording-initial-viewport branch February 3, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminfrueh benjaminfrueh benjaminfrueh approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr juliusknorr is a code owner

@silverkszlo silverkszlo Awaiting requested review from silverkszlo

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recording starts at origin / looks empty until first scroll (recording followUser doesn’t request viewport)

2 participants

@hweihwang @benjaminfrueh