PCA integration method implemented + tested#265
Open
gregothebyteknight wants to merge 4 commits intonf-core:devfrom
Open
PCA integration method implemented + tested#265gregothebyteknight wants to merge 4 commits intonf-core:devfrom
gregothebyteknight wants to merge 4 commits intonf-core:devfrom
Conversation
- add pca to integration methods (schema/docs/cellxgene list) wire SCANPY_PCA into INTEGRATE and publish outputs - use X_emb for PCA in integrated AnnData for downstream consistency
nictru
reviewed
Mar 12, 2026
nictru
requested changes
Mar 12, 2026
Collaborator
nictru
left a comment
nictru
left a comment
There was a problem hiding this comment.
Looks good so far! Can you just create a dedicated test in the INTEGRATE subworkflow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).