add test, test dynamic dimendsion field#9
Closed
weizijun wants to merge 1 commit intonik9000:tsid_genfrom
Closed
Conversation
Owner
|
Hey thanks! I'll going to convert this into a yaml test case and merge it to the main PR and investigate. The advantage of the yaml test cases is that we automatically pick them up in a bunch of extra contexts - multi-node, mixed version cluster to simulate a rolling restart, with security enabled, stuff like that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, Nik, I add a test to test dynamic field case.
when a filed with dimendsion=true in dynamic template, but not in properties, _tsid will not use this field.
but when the second time, the new field added in properties, _tsid will use this field.
It will case the different routing and _tsid.