Implement `on-mode-changed` callback

[wierdbytes]

Good day,

I've been interested in AeroSpace for a while, and I've recently decided to try using it as a daily replacement for yabai.

I really like the concept of bindings, and I've decided to move all control functions into a separate mode (except for focus commands). This requires a convenient indication of this mode to remind me to exit back to the main mode - the built-in AeroSpace widget for the macOS menu bar handles this perfectly. However, my issue is that I use sketchybar, and the built-in menu bar automatically hides.

I've already implemented workspace display and switching for sketchybar using on-focus-changed / exec-on-workspace-change. However, when searching for similar callbacks about switching the binding mode, I couldn't find one.

Could you please advise if I might have missed this in the documentation? If so, I'd appreciate a link to the relevant section.

If such functionality is not currently implemented, I'd like to suggest expanding the list of callbacks to include a new one that would be triggered when the binding mode changes.

[nikitabobko]

Workaround: you can manually trigger sketchybar changes every time you call mode command

The request makes sense, I don't mind adding on-mode-changed callback similar to on-focus-changed if anybody decides to submit the PR. The issue has minor priority to me

Open design question: shall the on-mode-changed callback be "recursion resistant" similarly to on-focus-changed?

[martinengelke]

Like Nikita said, you could temporarily (which may not to be seen as a workaround, since it gives you the ability to determine a specific icon for EACH mode) use this:

[mode.main.binding]
# Enter service mode
cmd-ctrl-alt-shift-space = ['mode service', 'exec-and-forget sketchybar --add item service q --set service icon=service --set service background.drawing=off --set service icon.color=0xff2cf9ed']

where q is next to the notch (could also used left instead)

and in the binding mode itself you can just add to your exit-routine:

[mode.service.binding]
esc = ['reload-config', 'exec-and-forget sketchybar --remove service', 'mode main']

[pszypowicz]

I would too prefer to have native trigger, but till then I have it configured like here: https://github.com/pszypowicz/dotfiles/blob/f4b6f0da76f7837cf9092dc4be940d4af8bfc993/dot-aerospace.toml#L166-L206

[martinengelke]

Actually I am going a little further and colorise the whole bar, so that I really don't miss to jump out of service ^^

aerospace mode service ; sketchybar --bar color=0x80ff2453

and back on ESC

esc = ['reload-config', 'exec-and-forget sketchybar --reload', 'exec-and-forget sketchybar --bar color=0x#ffffff00', 'mode main']

[khoinguyen]

exec-and-forget can work, but when adding more stuff in service mode, it will be come tedious. +1 for a on-mode-changed

[x41lakazam]

+1 as a lot of functions in my service mode automatically switches back to main mode, would be easier to have a callback

[epicwhale]

+1

[rQxwX3]

+1

[igarcez]

+1 for making it easier when using multiple and/or nested modes