Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using exposing decimal container is good so that other code that uses this money type can also work with coefficient and other numerics expressed in decimals of compatible type. such as if we have currency in fp3 and some other coefficients in fp3, then they can work together
however, this does not work for now. currencies leak precision with less that 3 units
then there is issue with amount is in fp2 and coefficient in fp3, leading to leaks of money precision
using fp2 will not help. as KRW and JPY will leak into fractions.
no simple way to address this for now. keeping dynamic precision for now. sigh.
for sake of currency precision, not exposing underlying decimal container.
keeping PR open for future