Open
Conversation
Owner
|
Hi, thank you for your contribution. Unfortunately I won't be able to review the issue and the patch until next week. Thank you for your patience. |
Author
|
Hi @nilp0inter, Have you had the opportunity to consider my above adjustments? Could you let me know whether or not you intend to include them in a new version of experta? Depending on your answer, I code adjust the code of the project I am working on in a future-proof way. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #17, at least it works for the minimal working example provided (#17 (comment)) and the actual code I have.
To be checked though, because I'm not entirely sure of the behaviour of
self.last_indexandself.reference_counter.