Open
Conversation
Removes an unused parameter from the callback stored in `NimProg` object. It's confusing and was ever only called with an empty string to signal "read argv". Any mock/testing procs just ignore it.
Contributor
Author
|
As far as I understand, the tests don't pass as the Nimony ref is baked in and the used and updated API conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes an unused parameter from the callback stored in
NimProgobject. It's confusing and was everonly called with an empty string to signal "read argv".
Any mock/testing procs just ignore this parameter.
This is a preparation to #25571 or whatever replaces it. After this change the tools should be prepared to every reasonable API change to parseopt, whatever it's going to be.
Nimony repo also relies on
cmdlinehelperso a companion PR is following.