Skip to content

fix usage of nim's compiler/cmdlinehelper #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZoomRmc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix usage of nim's compiler/cmdlinehelper #1679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/gear2/gear2.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,8 @@ proc commandCheck(graph: ModuleGraph) =
#let dest = moduleSuffix(toFullPath(conf, module.fileIdx))
#toNif(conf, module.ast, conf.nimcacheDir / dest.addFileExt".nif")

proc processCmdLine(pass: TCmdLinePass, cmd: string; config: ConfigRef) =
var p = parseopt.initOptParser(cmd)
proc processCmdLine(pass: TCmdLinePass; config: ConfigRef) =
var p = parseopt.initOptParser()
var argsCount = 0

config.commandLine.setLen 0
Expand Down
4 changes: 2 additions & 2 deletions src/nifler/configcmd.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
return true
return fileExists(pd.string / nimbleLock)

proc processCmdLine(pass: TCmdLinePass, cmd: string; config: ConfigRef) =
var p = parseopt.initOptParser(cmd)
proc processCmdLine(pass: TCmdLinePass; config: ConfigRef) =
var p = parseopt.initOptParser()
var argsCount = 0

config.commandLine.setLen 0
Expand Down Expand Up @@ -61,7 +61,7 @@
proc handleCmdLine(cache: IdentCache; conf: ConfigRef) =
let self = NimProg(
supportsStdinFile: true,
processCmdLine: processCmdLine

Check failure on line 64 in src/nifler/configcmd.nim

View workflow job for this annotation

GitHub Actions / macos-arm64-nim-devel (master) 

type mismatch: got 'proc (pass: TCmdLinePass, config: ConfigRef){.gcsafe.}' for 'processCmdLine' but expected 'proc (pass: TCmdLinePass, cmd: string, config: ConfigRef){.closure.}'

Check failure on line 64 in src/nifler/configcmd.nim

View workflow job for this annotation

GitHub Actions / linux-i386-nim-devel (master) 

type mismatch: got 'proc (pass: TCmdLinePass, config: ConfigRef){.gcsafe.}' for 'processCmdLine' but expected 'proc (pass: TCmdLinePass, cmd: string, config: ConfigRef){.closure.}'

Check failure on line 64 in src/nifler/configcmd.nim

View workflow job for this annotation

GitHub Actions / linux-amd64-nim-devel (master) 

type mismatch: got 'proc (pass: TCmdLinePass, config: ConfigRef){.gcsafe.}' for 'processCmdLine' but expected 'proc (pass: TCmdLinePass, cmd: string, config: ConfigRef){.closure.}'
)
self.initDefinesProg(conf, "nim_compiler")
if paramCount() == 0:
Expand Down
Loading