home-manager-auto-upgrade by s0racat · Pull Request #8353 · nix-community/home-manager

s0racat · 2025-12-15T13:26:37Z

Description

Added a new preSwitchCommands option to allow users to run arbitrary commands before home-manager switch.
Added a new flags option to allow users to pass additional options to home-manager switch
fix bug: home-manager-auto-upgrade service is stopped by reloadSystemd. #8349

Checklist

Change is backwards compatible.
Code formatted with nix fmt or
nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.
Code tested through nix run .#tests -- test-all or
nix-shell --pure tests -A run.all.
Test cases updated/added. See example.
[] Commit messages are formatted like
```
{component}: {description}

{long description}
```
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
- Added myself as module maintainer. See example.
- Generate a news entry. See News
- Basic tests added. See Tests
If this PR adds an exciting new feature or contains a breaking change.
- Generate a news entry. See News

pinage404 · 2025-12-15T23:42:28Z

I don't use it since a while

Could you remove me as a maintainer please ?

I may review later

s0racat · 2025-12-16T03:11:39Z

I don't use it since a while

Could you remove me as a maintainer please ?

I may review later

I removed you from the maintainers and added me.
Review this PR please.
Thanks.

s0racat · 2025-12-16T15:58:24Z

Please do not merge this pull request.
I'll try to improve module and eliminate error

s0racat · 2025-12-17T09:11:15Z

@pinage404
I’ve finished fixing this module.
Please review it.

pinage404 · 2026-01-10T13:57:21Z

+          - null: use legacy behavior (deprecated)
+          - []: run no pre-switch commands


thought(non-blocking): i am surprised,i think i have never seen this kind of behavior before in Nix's options

i would not be surprise to have another option like behavior with values legacy or explicit

Changed to use legacy behavior when preSwitchCommands is not set (=null).
I also find this implementation confusing

pinage404 · 2026-01-10T14:06:20Z

          echo "Changing to flake directory $FLAKE_DIR"
          cd "$FLAKE_DIR"
-          echo "Update flake inputs"
-          nix flake update


thought(non-blocking): maybe this should go in the preSwitchScript

What do you think about it ?

These lines are not included in the latest changes.

Sorry, i put the comment in the wrong line

pinage404 · 2026-01-10T14:10:12Z

-        Unit.Description = "Home Manager upgrade";
+        Unit = {
+          Description = "Home Manager upgrade";
+          X-SwitchMethod = "keep-old";


question(blocking): i don't understand this line :

What is the purpose of it ?

Is it a standard thing of SystemD ?

Is it a standard thing of Home Manager ?

Do there is any doc about it somewhere ?

I would prefer to understand every line before approving something

What is the purpose of it ?
Prevent restart unit by reloadSystemd hook

Is it a standard thing of SystemD ?
no. X prefix used for systemd's non-standard options

Is it a standard thing of Home Manager ?
yes.

Do there is any doc about it somewhere ?
https://nix-community.github.io/home-manager/options.xhtml#opt-systemd.user.services._name_.Unit.Documentation

pinage404 · 2026-01-10T23:45:06Z

Maybe it could be worth to add a note in the release notes ?

s0racat · 2026-01-11T01:37:44Z

Maybe it could be worth to add a note in the release notes ?

It might be good to add.

pinage404 · 2026-01-11T16:03:22Z

          echo "Changing to flake directory $FLAKE_DIR"
          cd "$FLAKE_DIR"
-          echo "Update flake inputs"
-          nix flake update


Sorry, i put the comment in the wrong line

pinage404 · 2026-01-11T16:03:37Z

+          echo "Update Nix channels"
          nix-channel --update


thought(non-blocking): maybe this should go in the preSwitchScript

What do you think about it ?

I thought nix-channel --update was required for non-flake users.
Is there any other good way to implement it?

Maybe they could have manually pinned every dependency in their repo and would like to override with a simpler git pull ?

pinage404 · 2026-01-11T16:06:07Z

-        Unit.Description = "Home Manager upgrade";
+        Unit = {
+          Description = "Home Manager upgrade";
+          X-SwitchMethod = "keep-old";


pinage404 · 2026-01-13T22:57:29Z

I don't know the standard format for this, i will let home-manager's maintainer check this

khaneliman

Please fixup/squash commits to follow contribution guidelines.

s0racat · 2026-01-27T07:50:08Z

pr status ?
please rereview code @khaneliman

s0racat · 2026-03-04T23:43:39Z

could you like to review code @khaneliman

Add a flags option for passing extra arguments to home-manager switch and a preSwitchCommands option for running commands before the switch. Preserve the legacy flake update behavior behind a deprecation warning, clean up the shell script, and cover the flake path in tests.

Improve the option descriptions for enable, useFlake, flakeDir, and the systemd timer format.

Document the new flags and preSwitchCommands options for the auto-upgrade service.

Migrate the preSwitchCommands default to lib.hm.deprecations.mkStateVersionOptionDefault instead of using a null sentinel. Keep the legacy flake update behavior for older state versions and add tests for the explicit, legacy, and current flake paths.

khaneliman · 2026-04-23T00:21:51Z

Alright, organized the commits and migrated the default deprecation to use my new state version helper.

s0racat · 2026-04-23T00:26:19Z

thank you for fixing!

github-actions Bot added the system label Dec 15, 2025

home-manager-ci Bot requested a review from pinage404 December 15, 2025 13:27

s0racat changed the title ~~Home manager auto upgrade~~ home-manager-auto-upgrade Dec 15, 2025

pinage404 reviewed Jan 10, 2026

View reviewed changes

pinage404 approved these changes Jan 11, 2026

View reviewed changes

pinage404 approved these changes Jan 13, 2026

View reviewed changes

khaneliman requested changes Jan 14, 2026

View reviewed changes

Comment thread modules/misc/news/2026/01/2026-01-13_10-11-50.nix Outdated

Comment thread modules/services/home-manager-auto-upgrade.nix

s0racat requested a review from khaneliman January 25, 2026 05:05

github-actions Bot added the merge conflict label Apr 9, 2026

khaneliman force-pushed the home-manager-auto-upgrade branch 2 times, most recently from b4d785a to 2185669 Compare April 22, 2026 23:42

s0racat added 5 commits April 22, 2026 18:45

maintainers: add soracat

d343766

home-manager-auto-upgrade: set maintainer to soracat

7d5dfc9

home-manager-auto-upgrade: clarify option documentation

4dd062a

Improve the option descriptions for enable, useFlake, flakeDir, and the systemd timer format.

news: add home-manager-auto-upgrade options entry

a525c56

Document the new flags and preSwitchCommands options for the auto-upgrade service.

khaneliman force-pushed the home-manager-auto-upgrade branch from 2185669 to a525c56 Compare April 22, 2026 23:45

khaneliman merged commit 667b3c4 into nix-community:master Apr 23, 2026
8 checks passed

		- null: use legacy behavior (deprecated)
		- []: run no pre-switch commands

Uh oh!

Conversation

s0racat commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

pinage404 commented Dec 15, 2025

Uh oh!

s0racat commented Dec 16, 2025

Uh oh!

s0racat commented Dec 16, 2025

Uh oh!

s0racat commented Dec 17, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pinage404 commented Jan 10, 2026

Uh oh!

s0racat commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khaneliman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

s0racat commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s0racat commented Mar 4, 2026

Uh oh!

khaneliman commented Apr 23, 2026

Uh oh!

s0racat commented Apr 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

s0racat commented Dec 15, 2025 •

edited

Loading

s0racat commented Jan 11, 2026 •

edited

Loading

s0racat commented Jan 27, 2026 •

edited

Loading