modules/keymaps: improve lua deprecation#1795
Closed
MattSturgeon wants to merge 1 commit intonix-community:mainfrom
Closed
modules/keymaps: improve lua deprecation#1795MattSturgeon wants to merge 1 commit intonix-community:mainfrom
lua deprecation#1795MattSturgeon wants to merge 1 commit intonix-community:mainfrom
Conversation
- Take advantage of the module system in the keymap submodule - Use `showDefs` to better print the actual definitions and locations (e.g. improves how `_type="override"` is shown) - Removed `normalizeMapping` (inlined into `action`'s `apply` function) - Also show warning for `keymapsOnEvent`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showDefsto better print the actual definitions and locations(e.g. improves how
_type="override"is shown)normalizeMapping(inlined intoaction'sapplyfunction)keymapsOnEventTesting
When adding the following test case:
The following warning is printed:
Note:
mkDefault truecorrectly prints astruethanks to usingshowDefsrather thantoPretty.luaDefssubmodule config not becauseshowDefsstrips them. So this is actually unintended behavior!<unknown-file>is shown because I used a test case, this would normally be an actual file path.Extra submodule option
To access
options.lua.definitionsWithLocationsfrom outside the submodule, I created aluaDefsoption. This probably isn't the correct approach, but IDK how to correctly access theluasub-option from outside a list of submodule.