plugins/nvim-snippets: init#1979
Merged
mergify[bot] merged 2 commits intonix-community:mainfrom Aug 7, 2024
Merged
Conversation
GaetanLepage
approved these changes
Aug 3, 2024
Member
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
Thanks for this contribution.
Your PR looks promising !
I made a few minor remarks.
GaetanLepage
requested changes
Aug 3, 2024
Member
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
A bit more nit-picking...
Merged
GaetanLepage
requested changes
Aug 6, 2024
Member
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
This looks good to me !
@nix-community/nixvim could you please double-check quickly ?
@psfloyd, please squash your commits so as to have two left:
maintainers: add psfloydplugins/nvim-snippets: init
MattSturgeon
reviewed
Aug 6, 2024
Member
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
One nit, otherwise LGTM once other feedback is addressed!
Contributor
Author
|
It's ready to merge from my part. Squashed the commits and fixed the unnedded newline. |
Member
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at c9a855f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for nvim-snippets.