Skip to content

lib/modules: add evalNixvim#1985

Merged
mergify[bot] merged 1 commit intonix-community:mainfrom
MattSturgeon:lib_eval-nixvim
Aug 20, 2024
Merged

lib/modules: add evalNixvim#1985
mergify[bot] merged 1 commit intonix-community:mainfrom
MattSturgeon:lib_eval-nixvim

Conversation

@MattSturgeon
Copy link
Copy Markdown
Member

Evaluates a nixvim config, by default also checking warnings and assertions.

This used internally by the standalone wrapper.

I'm planning to use this to refactor the tests implementation:

  • The tests don't need a "full" standalone build
  • The tests should be able to expect/reject warnings/assertions
  • Warnings should fail tests (unless marked as expected)

But I figured it'd be easier to test/review if I push this as a separate PR.

@MattSturgeon
Copy link
Copy Markdown
Member Author

MattSturgeon commented Aug 4, 2024

Looking at the implementations in #1986 and #1989, I'm wondering if the interface here is a little over-engineered?

I think the only place where we'd use it with the default values would be the standalone wrapper 🫤

@MattSturgeon
Copy link
Copy Markdown
Member Author

MattSturgeon commented Aug 18, 2024

Looking at the implementations in #1986 and #1989, I'm wondering if the interface here is a little over-engineered?

This is resolved in the latest force-push, however I still think we can simplify things further by moving the warning/assertion handling to finalPackage's evaluation; similar to how nixos checks warnings/assertions while evaluating the activation package option.

EDIT: maybe this wouldn't make sense, since we don't want to check assertions/warnings on hosted wrappers, instead we pass our assertions/warnings up to the host's option...

@MattSturgeon MattSturgeon requested a review from a team August 18, 2024 21:42
Evaluates a nixvim config, by default also checking warnings and assertions.

This used internally by the standalone wrapper.
@nix-community nix-community deleted a comment from mergify bot Aug 20, 2024
@MattSturgeon
Copy link
Copy Markdown
Member Author

@Mergifyio queue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 20, 2024

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 851edc8

@mergify mergify bot merged commit 851edc8 into nix-community:main Aug 20, 2024
@mergify mergify bot temporarily deployed to github-pages August 20, 2024 21:26 Inactive
@MattSturgeon MattSturgeon deleted the lib_eval-nixvim branch August 20, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants