Fix for obsolete nerdfont icons#2016
Closed
hansemschnokeloch wants to merge 1 commit intonix-community:mainfrom
Closed
Fix for obsolete nerdfont icons#2016hansemschnokeloch wants to merge 1 commit intonix-community:mainfrom
hansemschnokeloch wants to merge 1 commit intonix-community:mainfrom
Conversation
khaneliman
reviewed
Aug 13, 2024
| TODO = { icon = " "; color = "info"; }; | ||
| HACK = { icon = " "; color = "warning"; }; | ||
| WARN = { icon = " "; color = "warning"; alt = [ "WARNING" "XXX" ]; }; | ||
| PERF = { icon = " "; alt = [ "OPTIM" "PERFORMANCE" "OPTIMIZE" ]; }; |
Contributor
There was a problem hiding this comment.
This looks like the defaults section for the plugin, the defaults I see in their config uses a different icon:
PERF = { icon = " ", alt = { "OPTIM", "PERFORMANCE", "OPTIMIZE" } },
| HACK = { icon = " "; color = "warning"; }; | ||
| WARN = { icon = " "; color = "warning"; alt = [ "WARNING" "XXX" ]; }; | ||
| PERF = { icon = " "; alt = [ "OPTIM" "PERFORMANCE" "OPTIMIZE" ]; }; | ||
| NOTE = { icon = " "; color = "hint"; alt = [ "INFO" ]; }; |
Contributor
There was a problem hiding this comment.
Same as other, looks like a different default icon:
NOTE = { icon = " ", color = "hint", alt = { "INFO" } },
Contributor
Author
There was a problem hiding this comment.
That's a good point, I obviously got confused with my own local config.
I updated the PR
Contributor
There was a problem hiding this comment.
They should still be nix attributes. I was just posting the lua from the plugin.
These two icons are removed from nerdfont. See https://www.nerdfonts.com/cheat-sheet
hansemschnokeloch
force-pushed
the
patch-1
branch
from
d25d30e to
9985956
Compare
Contributor
|
Appreciate your PR, but will be superseded by #2030 migration PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two icons are removed from nerdfont.
See https://www.nerdfonts.com/cheat-sheet and search for
clock_fastandmessage_reply_text