Skip to content

plugins/todo-comments: migrate keymaps to mkMapOptionSubmodule#2046

Merged
mergify[bot] merged 1 commit intonix-community:mainfrom
khaneliman:todo
Aug 20, 2024
Merged

plugins/todo-comments: migrate keymaps to mkMapOptionSubmodule#2046
mergify[bot] merged 1 commit intonix-community:mainfrom
khaneliman:todo

Conversation

@khaneliman
Copy link
Copy Markdown
Contributor

@khaneliman khaneliman commented Aug 20, 2024

Follow up to #2030 can now be done since #2040 is implemented.

Copy link
Copy Markdown
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

Copy link
Copy Markdown
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action in the plugin's keymap options should just be the attr values from keymapsActions,

We then later interpolate it into the "full" action for use in the top-level keymaps.

Copy link
Copy Markdown
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@khaneliman
Copy link
Copy Markdown
Contributor Author

@Mergifyio queue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 20, 2024

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at cb41399

@mergify mergify bot merged commit cb41399 into nix-community:main Aug 20, 2024
@mergify mergify bot temporarily deployed to github-pages August 20, 2024 04:39 Inactive
@khaneliman khaneliman deleted the todo branch August 20, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants