Skip to content

lsd: init#2080

Open
sand4rt wants to merge 5 commits intonix-community:masterfrom
sand4rt:lsd
Open

lsd: init#2080
sand4rt wants to merge 5 commits intonix-community:masterfrom
sand4rt:lsd

Conversation

@sand4rt
Copy link
Copy Markdown

@sand4rt sand4rt commented Dec 9, 2025

for reference; https://github.com/lsd-rs/lsd/blob/main/doc/samples/colors-sample.yaml


@stylix-automation stylix-automation bot added topic: home-manager Home Manager target topic: testbed Testbed changes topic: modules /modules/ subsystem topic: stylix /stylix/ subsystem labels Dec 9, 2025
@trueNAHO trueNAHO added the backport: release-25.11 To be backported to the release-25.11 stable branch label Dec 9, 2025
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference; https://github.com/lsd-rs/lsd/blob/main/doc/samples/colors-sample.yaml

What value does this explicit theme provide over the LS_COLORS environment variable, which we support due to #560?

CC: @arunoruto, @i-am-logger, @jeanlucthumm, @tuxiqae

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess something like coloring git repos differently is not supported by LS_COLORS.
But even the maintainers suggest using LS_COLORS for most of the things: lsd-rs/lsd#402

@sand4rt can you take a look at the list here and make a comparison with theming options of lsd?
https://www.bigsoft.co.uk/blog/2008/04/11/configuring-ls_colors

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunoruto This isn’t about styling files and directories—that’s what LS_COLORS handles, as the maintainer mentioned. This is about customizing the colors of specific lsd UI components, such as git status indicators or tree edges. The config for these components does not conflict with LS_COLORS.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems about right, I thought LS_COLORS themes more than just the folders, but maybe that depends on the ls binary being used!
have you tested how it looks like when both vivid and lsd themes are on? Would be nice if the themes are consistent :)

Copy link
Copy Markdown
Author

@sand4rt sand4rt Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i use both vivid and lsd

Copy link
Copy Markdown
Member

@trueNAHO trueNAHO Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i use both vivid and lsd

Could you provide demonstrative screenshots for the following cases:

vivid (LS_COLOR) lsd
disabled enabled
enabled disabled
enabled enabled

Consider temporarily modifying the following relevant testbeds for doing the screenshots:

  • nix run .#testbeds:lsd:dark
  • nix run .#testbeds:vivid:dark

Otherwise, if you want to do it locally, ensure the LS_COLOR environment variable is not accidentally kept on when it should be disabled. To be safe this probably requires a full logout and login.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vivid  lsd screenshot
disabled enabled screenshot-p1769291472
enabled disabled screenshot-p1769291723
enabled enabled screenshot-p1769291862

Copy link
Copy Markdown
Contributor

@arunoruto arunoruto Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the screenshots! Seems like LS_COLORS takes precedence in coloring the folders! But it also styles other aspects too!

Just a small nitpick and correct me if I am wrong, but maybe keep lsd enabled as a module, but disable the theming option of lsd. This would mean we run lsd with no theming, but with LS_COLORS active.

Copy link
Copy Markdown
Author

@sand4rt sand4rt Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like LS_COLORS takes precedence in coloring the folders!

Yes, that’s correct.

Just a small nitpick and correct me if I am wrong, but maybe keep lsd enabled as a module, but disable the theming option of lsd. This would mean we run lsd with no theming, but with LS_COLORS active.

Not sure if that makes sense.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this type of theming lsd is okay, maybe we should revisit #545.

Ideally, LS_COLORS covers everything without needing individual applications to explicitly extend its theming support, ensuring theme consistency by only relying on LS_COLORS.

However, I would also be fine with extending theming support. Let me know what you think.

@stylix-automation stylix-automation bot added the status: merge conflict Merge conflict label Dec 11, 2025
Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
@sand4rt sand4rt requested a review from trueNAHO January 23, 2026 13:26
Copy link
Copy Markdown
Member

@trueNAHO trueNAHO Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i use both vivid and lsd

Could you provide demonstrative screenshots for the following cases:

vivid (LS_COLOR) lsd
disabled enabled
enabled disabled
enabled enabled

Consider temporarily modifying the following relevant testbeds for doing the screenshots:

  • nix run .#testbeds:lsd:dark
  • nix run .#testbeds:vivid:dark

Otherwise, if you want to do it locally, ensure the LS_COLOR environment variable is not accidentally kept on when it should be disabled. To be safe this probably requires a full logout and login.

Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
@stylix-automation stylix-automation bot removed the status: merge conflict Merge conflict label Jan 23, 2026
@arunoruto
Copy link
Copy Markdown
Contributor

If this type of theming lsd is okay, maybe we should revisit #545.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport: release-25.11 To be backported to the release-25.11 stable branch topic: home-manager Home Manager target topic: modules /modules/ subsystem topic: stylix /stylix/ subsystem topic: testbed Testbed changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants