Conversation
There was a problem hiding this comment.
for reference; https://github.com/lsd-rs/lsd/blob/main/doc/samples/colors-sample.yaml
What value does this explicit theme provide over the LS_COLORS environment variable, which we support due to #560?
There was a problem hiding this comment.
I guess something like coloring git repos differently is not supported by LS_COLORS.
But even the maintainers suggest using LS_COLORS for most of the things: lsd-rs/lsd#402
@sand4rt can you take a look at the list here and make a comparison with theming options of lsd?
https://www.bigsoft.co.uk/blog/2008/04/11/configuring-ls_colors
There was a problem hiding this comment.
@arunoruto This isn’t about styling files and directories—that’s what LS_COLORS handles, as the maintainer mentioned. This is about customizing the colors of specific lsd UI components, such as git status indicators or tree edges. The config for these components does not conflict with LS_COLORS.
There was a problem hiding this comment.
Seems about right, I thought LS_COLORS themes more than just the folders, but maybe that depends on the ls binary being used!
have you tested how it looks like when both vivid and lsd themes are on? Would be nice if the themes are consistent :)
There was a problem hiding this comment.
Yeah i use both vivid and lsd
There was a problem hiding this comment.
Yeah i use both vivid and lsd
Could you provide demonstrative screenshots for the following cases:
vivid (LS_COLOR) |
lsd |
|---|---|
| disabled | enabled |
| enabled | disabled |
| enabled | enabled |
Consider temporarily modifying the following relevant testbeds for doing the screenshots:
nix run .#testbeds:lsd:darknix run .#testbeds:vivid:dark
Otherwise, if you want to do it locally, ensure the LS_COLOR environment variable is not accidentally kept on when it should be disabled. To be safe this probably requires a full logout and login.
There was a problem hiding this comment.
Thanks for the screenshots! Seems like LS_COLORS takes precedence in coloring the folders! But it also styles other aspects too!
Just a small nitpick and correct me if I am wrong, but maybe keep lsd enabled as a module, but disable the theming option of lsd. This would mean we run lsd with no theming, but with LS_COLORS active.
There was a problem hiding this comment.
Seems like LS_COLORS takes precedence in coloring the folders!
Yes, that’s correct.
Just a small nitpick and correct me if I am wrong, but maybe keep lsd enabled as a module, but disable the theming option of lsd. This would mean we run lsd with no theming, but with LS_COLORS active.
Not sure if that makes sense.
There was a problem hiding this comment.
If this type of theming lsd is okay, maybe we should revisit #545.
Ideally, LS_COLORS covers everything without needing individual applications to explicitly extend its theming support, ensuring theme consistency by only relying on LS_COLORS.
However, I would also be fine with extending theming support. Let me know what you think.
Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
There was a problem hiding this comment.
Yeah i use both vivid and lsd
Could you provide demonstrative screenshots for the following cases:
vivid (LS_COLOR) |
lsd |
|---|---|
| disabled | enabled |
| enabled | disabled |
| enabled | enabled |
Consider temporarily modifying the following relevant testbeds for doing the screenshots:
nix run .#testbeds:lsd:darknix run .#testbeds:vivid:dark
Otherwise, if you want to do it locally, ensure the LS_COLOR environment variable is not accidentally kept on when it should be disabled. To be safe this probably requires a full logout and login.
Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
|
If this type of theming lsd is okay, maybe we should revisit #545. |



for reference; https://github.com/lsd-rs/lsd/blob/main/doc/samples/colors-sample.yaml