Skip to content

firefox: support Glide derivative#2240

Open
zzzealed wants to merge 5 commits intonix-community:masterfrom
zzzealed:add-glide-browser
Open

firefox: support Glide derivative#2240
zzzealed wants to merge 5 commits intonix-community:masterfrom
zzzealed:add-glide-browser

Conversation

@zzzealed
Copy link
Copy Markdown

@zzzealed zzzealed commented Mar 16, 2026

Hello and thanks for your work on Stylix :)

I added Glide to the Firefox (and derivatives)-module, since Glide now has a Home Manager-module made with mkFirefoxModule. This means it should be compatible with the same options as the other derivatives.

I tested this myself and can confirm that the options looks to be working.

I hope I added everything correctly, as this is my first time making a contribution. Please do not hesitate to leave feedback or request changes.


@stylix-automation stylix-automation bot added topic: home-manager Home Manager target topic: modules /modules/ subsystem labels Mar 16, 2026
Copy link
Copy Markdown
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is currently failing because lib.maintainers.zzzealed and glide-browser are undefined. If these are recent upstream additions, this PR requires #2180 to be merged first.

  • Each commit in this PR is suitable for backport to the current stable branch

Are the necessary upstream patches available in our release-25.11 branch?

I hope I added everything correctly, as this is my first time making a contribution.

LGTM, except for one nitpick. I will also test this PR in a testbed once CI is working again.

@trueNAHO trueNAHO changed the title Add glide browser firefox: support Glide derivative Mar 17, 2026
@zzzealed
Copy link
Copy Markdown
Author

CI is currently failing because lib.maintainers.zzzealed and glide-browser are undefined. If these are recent upstream additions, this PR requires #2180 to be merged first.

Yeah so I removed myself as maintainer since I'm not in maintainer-list.nix. I hope this is fine.
For glide-browser being undefined, I think this happens because Glide isn't actually merged to nixpkgs yet. I use their flake's Home Manager module.
I don't know if Stylix has any policy on non-nixpkgs (yet) projects, like Glide. Please let me know if that's the case.

Are the necessary upstream patches available in our release-25.11 branch?

Yes it look's to me like release-25.11 has the sufficient patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: home-manager Home Manager target topic: modules /modules/ subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants