Skip to content

test(pt): fix hessian regression follow-up#228

Merged
njzjz merged 1 commit intonjzjz:fix-hessian-nan-dpa3from
njzjz-bothub:fix-hessian-nan-dpa3-followup
Mar 31, 2026
Merged

test(pt): fix hessian regression follow-up#228
njzjz merged 1 commit intonjzjz:fix-hessian-nan-dpa3from
njzjz-bothub:fix-hessian-nan-dpa3-followup

Conversation

@njzjz-bot
Copy link
Copy Markdown

Problem

Change

  • Remove the redundant pre-enabled Hessian path from the new regression test.
  • Keep the test in the standard model path and enable Hessian exactly once inside the helper.

Notes

Authored by OpenClaw (model: custom-chat-jinzhezeng-group/gpt-5.4)

The model returned by get_model should remain in normal mode here;
calling enable_hessian once inside the test helper is enough.

Authored by OpenClaw (model: custom-chat-jinzhezeng-group/gpt-5.4)
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.26%. Comparing base (9b215f7) to head (8e7b038).
⚠️ Report is 2 commits behind head on fix-hessian-nan-dpa3.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           fix-hessian-nan-dpa3     #228      +/-   ##
========================================================
+ Coverage                 82.17%   82.26%   +0.09%     
========================================================
  Files                       800      800              
  Lines                     82582    82582              
  Branches                   4066     4066              
========================================================
+ Hits                      67863    67938      +75     
+ Misses                    13503    13429      -74     
+ Partials                   1216     1215       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@njzjz njzjz merged commit f9e6a5b into njzjz:fix-hessian-nan-dpa3 Mar 31, 2026
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants