Skip to content

Conversation

@rvagg
Copy link
Member

@rvagg rvagg commented Apr 12, 2018

I've provisioned 2 test and 1 release smartos 17 machines and this is the required changes for ansible to get it set up. The only iffy bit that I bet there's a better answer for is the gcc7 links into /opt/local/bin, it's strange that there aren't links by default and there must be some kind of equivalent to debian style "alternatives". It works at least.

I've got rules in place to make Node >=10 binaries build on smartos 17, 64-bit only from 10 onward like for linux.

VersionSelectorScript.groovy now has the following:

  if (builderLabel.indexOf('smartos14') == 0 && nodeMajorVersion >= 8)
    return false
  if (builderLabel.indexOf('smartos15') == 0 && nodeMajorVersion < 8)
    return false
  if (buildType == 'release' && builderLabel.indexOf('smartos15') == 0 && nodeMajorVersion >= 10)
    return false
  if (builderLabel.indexOf('smartos16') == 0 && nodeMajorVersion < 8)
    return false
  if (builderLabel.indexOf('smartos17') == 0 && nodeMajorVersion < 10)
    return false

Roughly translated as:

  • releases:
    • Node 4 & 6: smartos14
    • Node 8: smartos15
    • Node 10+: smartos17
  • testing:
    • Node 4 & 6: smartos14
    • Node 8: smartos15, smartos16
    • Node 10+: smartos15, smartos16, smartos17

Builds from today onward (nightlies and the Node 10 test builds most notably) are using this configuration. Also including the absence of sunos-x86 binaries.

@geek

/ref #885
/ref #1149

gibfahn

This comment was marked as off-topic.

geek

This comment was marked as off-topic.

@rvagg
Copy link
Member Author

rvagg commented Apr 13, 2018

https://nodejs.org/download/nightly/v10.0.0-nightly201804120aab8ff602/ latest nightly has the new smartos binaries in it, and x64 only

@rvagg rvagg merged commit 22e4a15 into master Apr 13, 2018
@rvagg rvagg deleted the rvagg/smartos17 branch April 13, 2018 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants