Skip to content

jenkins: linter refactor & fix for 6.x #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
refack merged 6 commits into from
Aug 13, 2018
Merged

jenkins: linter refactor & fix for 6.x #1349

refack merged 6 commits into from
Aug 13, 2018

Conversation

@refack
Copy link
Contributor

@refack refack commented Jun 15, 2018

  • break down directive into single commands
  • don't fail if lint-md-build doesn't exist
  • replace sed with awk

@refack
jenkins: linter refactor & fix for 6.x
8716857 
* break down directive into single commands
* don't fail if `lint-md-build` doesn't exist
* replace `sed` with `awk`
@refack refack requested a review from maclover7 June 15, 2018 13:41
maclover7

This comment was marked as off-topic.

Sign in to view

@maclover7
Copy link
Contributor

maclover7 commented Jun 15, 2018

Also @refack can you please test this is a separate job next time, this is causing failures on node-linter: https://ci.nodejs.org/job/node-linter/

@refack
Copy link
Contributor Author

refack commented Jun 15, 2018 •
edited
Loading

can you please test this is a separate job next time

Ooops...
It started as a fix for node6...
I think I revered the call to tap2junit after I was done testing everything, stupid move.

@refack
Copy link
Contributor Author

refack commented Jun 15, 2018

Testing with:
https://ci.nodejs.org/job/ref-node-linter/14/ (node6)
https://ci.nodejs.org/job/ref-node-linter/15/ (master)
https://ci.nodejs.org/job/ref-node-linter/16/ (master with lint)

@refack
Copy link
Contributor Author

refack commented Jun 15, 2018

can you please test this is a separate job next time

Until we stabilize this I've reverted the job to last known stable config (i.e. using the file in the repo)

@refack
Copy link
Contributor Author

refack commented Jun 16, 2018

Tried to get the errors to display better
https://ci.nodejs.org/blue/organizations/jenkins/ref-node-linter/detail/ref-node-linter/44/pipeline
image

✔️ master
✔️ PR on node 6

maclover7

This comment was marked as off-topic.

Sign in to view

@richardlau richardlau mentioned this pull request Jun 17, 2018
Closed
mmarchini

This comment was marked as off-topic.

Sign in to view

@refack refack merged commit 5a68cf1 into nodejs:master Aug 13, 2018
@refack refack deleted the linter-pipeline-refactor-1 branch August 13, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@maclover7 maclover7 maclover7 approved these changes

@mmarchini mmarchini mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@refack @maclover7 @mmarchini