-
-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I recommend an emoji ✨ :sparkles:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏾 👋testing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boo, there aren't different skin tone emojis on github
|
Just to check my understanding: I think the idea is to get people started with the WG as quickly as possible. This WG is going to have more and more docs and policies and issues. People tend to skip to the important parts of the CONTRIBUTING to get to their goal as quickly as possible, so it's a good idea to make this as quick as possible by doing the leg work for them. In terms of just making the reading process more accessible, breaking something like this up into small parts makes a guide less overwhelming and thus more likely to be read. yeah? |
ebdd03f to
c4a81cd
Compare
|
yeah that's my goal @Charlotteis -- do you think the current structure works? i don't plan on adding much more except links. |
|
This is really clear and now that the appropriate emojis have been added, I'd be happy to see this merged :) |
|
LGTM! (so far at least) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need an extra newline after the title (or make them ### headings); the GitHub markdown renderer puts the text that follows on the same line
|
some minor formatting/link stuff; otherwise pretty solid :) |
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammar nit: wish to file an issue I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol that's not grammar its an entire missing word hahahah
22e010f to
b0349cf
Compare
b0349cf to
300187a
Compare
300187a to
55fa7d7
Compare
|
LGTM, merging! |
this is a draft for
CONTRIBUTING.md. this will be a ToC from which we link to all the things, e.g. issue structure, admissions, etc.cc: @nebrius @sup @Trott @Charlotteis