Skip to content

fix removal of v8::CopyablePersistent #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkoopa merged 1 commit into from
Jun 12, 2024
Merged

fix removal of v8::CopyablePersistent #970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions nan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,21 @@ typedef v8::String::ExternalOneByteStringResource
template<typename T>
class NonCopyablePersistentTraits :
public v8::NonCopyablePersistentTraits<T> {};
#if defined(V8_MAJOR_VERSION) && (V8_MAJOR_VERSION > 10 || \
(V8_MAJOR_VERSION == 10 && defined(V8_MINOR_VERSION) && V8_MINOR_VERSION >= 5))
template<typename T> struct CopyablePersistentTraits {
typedef v8::Persistent<T, CopyablePersistentTraits<T> > CopyablePersistent;
static const bool kResetInDestructor = true;
template <typename S, typename M>
static NAN_INLINE void Copy(const v8::Persistent<S, M> &source,
CopyablePersistent *dest) {
}
};
#else
template<typename T>
class CopyablePersistentTraits :
public v8::CopyablePersistentTraits<T> {};
#endif

template<typename T>
class PersistentBase :
Expand Down