Add `CloseEvent`

[regseb]

What is the problem this feature will solve?

The CloseEvent class isn't defined.

What is the feature you are proposing to solve the problem?

Add the CloseEvent class in the global scope. I found it in undici.

What alternatives have you considered?

Export CloseEvent class from events.

[bnoordhuis]

I'm inclined to say exporting CloseEvent doesn't make sense because it's a websockets things, something node doesn't support natively.

[regseb]

I thought WebSockets were implemented in Node. I use mock-socket which automatically adds the WebSocket class to the global scope, but not CloseEvent.

I agree to add CloseEvent when Node will support WebSocket. There is already an issue #19308 for adding WebSockets. And nodejs/undici#1795 already implements it, but it doesn't export CloseEvent https://github.com/nodejs/undici/pull/1795/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346:

    module.exports.getGlobalOrigin = getGlobalOrigin
  }

+ if (nodeMajor >= 18) {
+   const { WebSocket } = require('./lib/websocket/websocket')
+
+   module.exports.WebSocket = WebSocket
+ }
+
  module.exports.request = makeDispatcher(api.request)
  module.exports.stream = makeDispatcher(api.stream)
  module.exports.pipeline = makeDispatcher(api.pipeline)

[bnoordhuis]

I'll close this then. It's something we can revisit if and when node implements websockets.